Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not export common properties as schemas #424

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Apr 18, 2024

Closes #420

@mrlubos mrlubos requested a review from jordanshatford April 18, 2024 21:11
Copy link

changeset-bot bot commented Apr 18, 2024

🦋 Changeset detected

Latest commit: 901ed48

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mrlubos mrlubos marked this pull request as ready for review April 18, 2024 21:11
Copy link

vercel bot commented Apr 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 9:11pm

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.89%. Comparing base (b7b0859) to head (901ed48).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
+ Coverage   80.79%   80.89%   +0.09%     
==========================================
  Files          75       75              
  Lines        5208     5202       -6     
  Branches      582      581       -1     
==========================================
  Hits         4208     4208              
+ Misses        999      993       -6     
  Partials        1        1              
Flag Coverage Δ
unittests 80.89% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos merged commit c22aabd into main Apr 18, 2024
16 checks passed
@mrlubos mrlubos deleted the fix/schemas-export branch April 18, 2024 21:16
@github-actions github-actions bot mentioned this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not export common parameters when using schemas
2 participants