Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid typescript Record generated with circular dependencies #374

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

jordanshatford
Copy link
Collaborator

closes: #370

@jordanshatford jordanshatford requested a review from mrlubos April 12, 2024 23:06
Copy link

changeset-bot bot commented Apr 12, 2024

🦋 Changeset detected

Latest commit: 11ea5ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2024 11:32pm

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 83.84%. Comparing base (26a8914) to head (11ea5ad).

Files Patch % Lines
packages/openapi-ts/src/compiler/typedef.ts 16.66% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
- Coverage   84.00%   83.84%   -0.16%     
==========================================
  Files          73       73              
  Lines        4808     4817       +9     
  Branches      549      549              
==========================================
  Hits         4039     4039              
- Misses        768      777       +9     
  Partials        1        1              
Flag Coverage Δ
unittests 83.84% <16.66%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanshatford jordanshatford merged commit de22f5b into main Apr 12, 2024
14 of 16 checks passed
@jordanshatford jordanshatford deleted the fix/invalid-typescript branch April 12, 2024 23:43
@github-actions github-actions bot mentioned this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid typescript generated when using circular types
2 participants