Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schema): allow minimums/maximums to be 0 #194

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

jordanshatford
Copy link
Collaborator

No description provided.

@jordanshatford jordanshatford requested a review from mrlubos March 30, 2024 23:29
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 90.70%. Comparing base (e493d04) to head (a5730df).

Files Patch % Lines
src/utils/handlebars.ts 50.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
- Coverage   90.80%   90.70%   -0.11%     
==========================================
  Files          66       66              
  Lines        3990     4000      +10     
  Branches      477      477              
==========================================
+ Hits         3623     3628       +5     
- Misses        366      371       +5     
  Partials        1        1              
Flag Coverage Δ
unittests 90.70% <50.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mrlubos mrlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ( ͡° ͜ʖ ͡°)

@jordanshatford jordanshatford merged commit 813f67a into main Mar 30, 2024
12 of 14 checks passed
@jordanshatford jordanshatford deleted the fix/min-max-schema-values-of-zero branch March 30, 2024 23:35
@github-actions github-actions bot mentioned this pull request Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants