-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Wrap HEAD request in a try-catch to prevent watch mode crashes on server reloads #1748
Conversation
|
🦋 Changeset detectedLatest commit: 7326d25 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1748 +/- ##
==========================================
- Coverage 57.15% 57.14% -0.02%
==========================================
Files 191 191
Lines 25720 25728 +8
Branches 1913 1913
==========================================
Hits 14701 14701
- Misses 11010 11018 +8
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@hey-api/client-axios
@hey-api/client-fetch
@hey-api/client-next
@hey-api/client-nuxt
@hey-api/openapi-ts
commit: |
A quick fix on the problem discussed at #1542 (comment)
I'm not sure if this is the best approach, but I didn't want to go fiddling around with the json-schema-ref-parser library, which is causing the actual error to pop up so I wrote this and tested it out and it seemed to run without a hitch.
I also decided to pass the exception message to the response body but idk if that's what we want to do here.
Tested locally against the repro I posted here and another project and couldn't get it to crash.