Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add py2neo version 3 URI compatibility #8

Merged
merged 2 commits into from
Mar 2, 2017
Merged

Add py2neo version 3 URI compatibility #8

merged 2 commits into from
Mar 2, 2017

Conversation

veleritas
Copy link
Contributor

Hi Daniel,

Let me know if these changes are acceptable.

Toby

Tong Shu Li added 2 commits March 2, 2017 19:22
Add tqdm as a dependency
82e1c43 
Tqdm progress bars will be used to monitor Neo4j network import
progress.
Add progress bars to neo4j importer
35ba28f 
Add tqdm progress bars to the node and edge importing steps.
@dhimmel
Copy link
Member

dhimmel commented Mar 2, 2017

This PR continues #6. @veleritas any specific reason you opened a new PR?

@veleritas
Copy link
Contributor Author

Wasn't sure how the PR would work since some commits from the old PR were rebased away, so I figured it was easier just to open a new one?

dhimmel
dhimmel approved these changes Mar 2, 2017
View reviewed changes
Copy link
Member

@dhimmel dhimmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Will merge. Thanks for the enhancement!

@dhimmel dhimmel changed the title Version 3 Updates Add py2neo version 3 URI compatibility Mar 2, 2017
@dhimmel dhimmel merged commit 7fe01f1 into hetio:master Mar 2, 2017
@dhimmel
Copy link
Member

dhimmel commented Mar 2, 2017

Will try to get this on PyPI today as v0.2.1.

@veleritas
Copy link
Contributor Author

Isn't the current version already v0.2.1?

@dhimmel
Copy link
Member

dhimmel commented Mar 2, 2017

Isn't the current version already v0.2.1?

Good catch. PyPI is currently at v0.2.1 but I forgot to make a GitHub release. So next version will be v0.2.2 and I'll look into continuous deployment.

@dhimmel
Copy link
Member

dhimmel commented Mar 2, 2017

Wasn't sure how the PR would work since some commits from the old PR were rebased away, so I figured it was easier just to open a new one?

Yeah not a big deal. I probably would have force pushed after the rebase, but either is fine as long as they get linked in a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhimmel dhimmel dhimmel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@veleritas @dhimmel