You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for multiple selection via selectionMode "single" or "multiple" to the autocomplete component.
⛳️ Current behavior (updates)
The current behavior only allows single selection. This is because react-stately uses useComboStateProps, which only allows for single selection. The "multi" version in react-stately doesn't seem to be a complete project: adobe/react-spectrum#2140.
What I propose is to create a new hook called "useMultiComboBoxState" and tweak the original behavior to allow for both multiple and single selection.
🚀 New behavior
Allow the user to select multiple elements using selectionMode.
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information
This is a work in progress. Since this is my first PR, please don't hesitate to guide me through the coding and/or style.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
@jrgarciadev Sorry i'm not sure how i'm supposed to commit on the new branch you created, so i just forked again and created a new PR on you're newly created branch....
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
amauryfischer
changed the title
📝 Description
Add support for multiple selection via selectionMode "single" or "multiple" to the autocomplete component.
⛳️ Current behavior (updates)
The current behavior only allows single selection. This is because react-stately uses useComboStateProps, which only allows for single selection. The "multi" version in react-stately doesn't seem to be a complete project: adobe/react-spectrum#2140.
What I propose is to create a new hook called "useMultiComboBoxState" and tweak the original behavior to allow for both multiple and single selection.
🚀 New behavior
Allow the user to select multiple elements using selectionMode.
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information
This is a work in progress. Since this is my first PR, please don't hesitate to guide me through the coding and/or style.