Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Private Space create without DataCIDR #373

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Fix Private Space create without DataCIDR #373

merged 2 commits into from
Jun 15, 2023

Conversation

mars
Copy link
Member

@mars mars commented Jun 15, 2023

No description provided.

@mars mars changed the title Move default Private Space data CIDR to 10.2.0.1 Move default Private Space data CIDR to 10.2.0.0/16 Jun 15, 2023
@mars mars changed the title Move default Private Space data CIDR to 10.2.0.0/16 Fix Private Space create without DataCIDR Jun 15, 2023
alexmarnell
alexmarnell approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@alexmarnell alexmarnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for fixing

@mars mars marked this pull request as ready for review June 15, 2023 14:59
@mars mars merged commit 49d4874 into master Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmarnell alexmarnell alexmarnell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mars @alexmarnell