libcnb-test: Refactor the API for starting containers #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
force-pushed
the
edmorley/container-config
branch
from
5f7c6e1 to
f17a434
Compare
edmorley
force-pushed
the
edmorley/container-config
branch
from
f17a434 to
fa415d8
Compare
Previously container configuration was specified using a builder-style API, which was inconsistent with the API for `TestRunner::run_test`, and also slightly confusing at first glance (eg: for `TestContext::prepare_container` what does it mean to "prepare" a container?) Now, a new `TestContext::start_container` takes a `ContainerConfig` argument along with the closure, similar to `TestRunner::run_test` and `TestConfig`. In addition, a new convenience function for running a shell script (a common use-case) has been added (`TestContext::run_shell_command`) which handles more of the boilerplate than `PrepareContainerContext::start_with_shell_command` used to. In the future, this function will also check the exit status of the container (#446). GUS-W-11415596.
edmorley
force-pushed
the
edmorley/container-config
branch
from
fa415d8 to
f70a89a
Compare
Malax
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously container configuration was specified using a builder-style API, which was inconsistent with the API for
TestRunner::run_test, and also slightly confusing at first glance (eg: forTestContext::prepare_containerwhat does it mean to "prepare" a container?)Now, a new
TestContext::start_containertakes aContainerConfigargument along with the closure, similar toTestRunner::run_testandTestConfig.In addition, a new convenience function for running a shell script (a common use-case) has been added (
TestContext::run_shell_command) which handles more of the boilerplate thanPrepareContainerContext::start_with_shell_commandused to. In the future, this function will also check the exit status of the container (#446).GUS-W-11415596.