Improve the error message shown when Pack CLI is not installed #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
force-pushed
the
edmorley/handle-pack-not-installed
branch
from
f83b7ef to
984923d
Compare
Malax
approved these changes
Jul 6, 2022
Before:
```
---- basic_build stdout ----
thread 'basic_build' panicked at 'Could not spawn external 'pack' process: Os { code: 2, kind: NotFound, message: "No such file or directory" }', /Users/emorley/src/libcnb.rs/libcnb-test/src/test_runner.rs:188:14
```
After:
```
---- basic_build stdout ----
thread 'basic_build' panicked at 'External `pack` command not found. Install Pack CLI and ensure it is on PATH: https://buildpacks.io/docs/install-pack', /Users/emorley/src/libcnb.rs/libcnb-test/src/test_runner.rs:184:21
```
No integration test has been added, since writing one would
involve manipulating the `PATH` of the integration test process
which would be prone to intermittent test failures given concurrent
execution.
In addition all panic messages that reference "pack" now do so inside
backticks rather than single quotes, since the panic error message itself
is inside single quotes, so it looked like the quoted section had ended
prematurely.
Fixes #296.
GUS-W-11390631.
edmorley
force-pushed
the
edmorley/handle-pack-not-installed
branch
from
984923d to
721a314
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
No integration test has been added, since writing one would involve manipulating the
PATHof the integration test process which would be prone to intermittent test failures given concurrent test execution occurs in threads.In addition all panic messages that reference "pack" now do so inside backticks rather than single quotes, since the panic error message itself is inside single quotes, so it looked like the quoted section had ended prematurely.
Fixes #296.
GUS-W-11390631.