Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcnb-cargo: Disable unused stderrlog features #443

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

edmorley
Copy link
Member

@edmorley edmorley commented Jul 4, 2022

As of stderrlog v0.5.3 (cardoe/stderrlog-rs#45), it's possible to disable the timestamps feature of stderrlog (which we don't use), which otherwise requires the chrono dependency.

Doing so reduces the number of transitive dependencies by 5, and also removes Chrono from the dependency tree, which currently has reported CVEs so can cause security audit false positives.

GUS-W-11378865.

@edmorley edmorley added libcnb-cargo faster compiles Things that improve compile times labels Jul 4, 2022
@edmorley edmorley self-assigned this Jul 4, 2022
@edmorley
Copy link
Member Author

edmorley commented Jul 4, 2022

Between this and #442, libcnb-cargo now has 13 fewer dependencies (62 -> 49). This should help slightly with installation times eg in CI, where the "install libcnb-cargo" step can take up to 2 minutes.

@edmorley edmorley marked this pull request as ready for review July 4, 2022 09:47
@edmorley edmorley requested a review from a team as a July 4, 2022 09:47
@edmorley edmorley force-pushed the edmorley/fix-buildpack-size-output branch from 363acd9 to 2130aa0 Compare July 4, 2022 09:58
Base automatically changed from edmorley/fix-buildpack-size-output to main July 4, 2022 10:03
As of `stderrlog` v0.5.3, it's possible to disable the timestamps
feature of `stderrlog` (which we don't use), which otherwise requires
the `chrono` dependency. 

Doing so reduces the number of transitive dependencies by 5, and also
removes Chrono from the dependency tree, which currently has reported
CVEs so can cause security audit false positives.

GUS-W-11378865.
@edmorley edmorley force-pushed the edmorley/stderrlog-features branch from fe42696 to ee350ba Compare July 4, 2022 10:07
@edmorley edmorley enabled auto-merge (squash) July 4, 2022 10:08
@edmorley edmorley merged commit 1017360 into main Jul 4, 2022
@edmorley edmorley deleted the edmorley/stderrlog-features branch July 4, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
faster compiles Things that improve compile times libcnb-cargo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants