Fix verify_regex proc macro's error handling
#438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if an error was encountered whilst parsing the regex, a confusing internal macro error was emitted (see #437 for output). Now the actual regex error is output, eg: ``` error: Could not compile regular expression: Opening parenthesis without closing parenthesis --> examples/ruby-sample/src/main.rs:40:47 | 40 | let ruby_layer = context.handle_layer(layer_name!("ruby"), RubyLayer)?; | ^^^^^^^^^^^^^^^^^^^ | = note: this error originates in the macro `layer_name` (in Nightly builds, run with -Z macro-backtrace for more info) ``` See: https://docs.rs/syn/latest/syn/struct.Error.html https://stackoverflow.com/a/54394014 Fixes #437.
Malax
approved these changes
Jun 30, 2022
|
Nice find and fix! 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if an error was encountered whilst parsing the regex, a confusing internal macro error was emitted (see #437 for output).
Now the actual regex error is output, eg:
See:
https://docs.rs/syn/latest/syn/struct.Error.html
https://stackoverflow.com/a/54394014
Fixes #437.
GUS-W-11375177.