-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow running subsequent integration test builds #422
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f542682
to
31d6692
Compare
d147c30
to
f0e5ae1
Compare
52e3367
to
3159531
Compare
edmorley
approved these changes
Jun 23, 2022
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
45bda1f
to
603e1d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To achieve a consistent API, breaking changes had to be made to allow sharing of
TestConfig
(formerlyIntegrationTest
) for both initial and subsequent test runs. The biggest change is the addition ofTestRunner
which is now the way to run tests.Even though it's a breaking change, migration to this new API should be simple. See examples in this PR for an idea of required changes.
Changelog
IntegrationTest::run_test
, to run a test use the newTestRunner::run_test
function.IntegrationTest
toTestConfig
.IntegrationTestContext
toTestContext
.Clone
implementation forTestConfig
, allowing it to be shared across tests.TestContext::run_test
andTestContext::run_test_inherit_config
, allowing you to run subsequent integration tests with the image from a previous test. These functions allow testing of subsequent builds, including caching logic and buildpack behaviour when build environment variables change, stacks are upgraded and more.Examples
Closes #278, GUS-W-10539929