Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuildPlan Metadata Support #382

Merged
merged 7 commits into from
Mar 10, 2022
Merged

BuildPlan Metadata Support #382

merged 7 commits into from
Mar 10, 2022

Conversation

hone
Copy link
Member

@hone hone commented Mar 10, 2022

This fixes #350.

@hone hone requested a review from Malax March 10, 2022 00:05
@hone hone force-pushed the build-plan-refactor branch from f61d2d8 to be987be Compare March 10, 2022 00:23
@hone hone requested a review from Malax March 10, 2022 16:35
hone and others added 2 commits March 10, 2022 08:50
Co-authored-by: Manuel Fuchs <manuel.fuchs@salesforce.com>
Copy link
Member

@Malax Malax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to ignore the comment on the test. 👍🏻 Thanks for the PR!

@hone hone merged commit 06b33cc into main Mar 10, 2022
@hone hone deleted the build-plan-refactor branch March 10, 2022 18:08
@edmorley edmorley added the enhancement New feature or request label Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request libcnb-data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BuildPlanBuilder doesn't provide an API for setting requires.metadata
3 participants