Move libcnb-test TLS support behind a new remote-docker feature flag
#376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
added
libcnb-test
breaking change
faster compiles
Malax
approved these changes
Mar 7, 2022
Since: - Remote Docker support is only partly implemented (#307). - The unimplemented parts can cause user confusion: https://github.com/Malax/libcnb.rs/issues/364#issuecomment-1057246583 - The bollard `ssl` feature adds another 17 dependencies, which are unused by projects not using remote docker (which is all projects at the moment). This dependency count difference will increase to 25, once a new bollard release exists that includes fussybeaver/bollard#204. Fixes #364.
edmorley
force-pushed
the
edmorley/remote-docker-optional
branch
from
69a998c to
049c646
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since:
sslfeature adds another 17 dependencies, which are unused by projects not using remote docker (which is all projects at the moment). This dependency count difference will increase to 25, once a new bollard release exists that includes Make remaining ssl-only dependencies optional fussybeaver/bollard#204.Fixes #364.
GUS-W-10801321.