-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package all binary targets #314
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b57a480
to
bb29cf8
Compare
bb0985f
to
a0ae475
Compare
edmorley
reviewed
Feb 11, 2022
d08a9df
to
53c43de
Compare
edmorley
approved these changes
Feb 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - thank you :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first of a series of PRs to support exec.d across libcnb.
Changes
libcnb-cargo
andlibcnb-test
to package all binaries of a buildpack crate into the final buildpack. Previously, a buildpack crate could only contain one binary target. Allowing multiple binaries enables use-cases likeexec.d
binaries written in Rust that exist in the buildpack that uses them. These binaries will be packaged into.libcnb-cargo/additional-bin/$TARGET_NAME
.An additional PR that is coming soon will make it easier to reference these binaries via macros at build time.
Closes GUS-W-10670969