Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package all binary targets #314

Merged
merged 7 commits into from
Feb 14, 2022
Merged

Package all binary targets #314

merged 7 commits into from
Feb 14, 2022

Conversation

Malax
Copy link
Member

@Malax Malax commented Feb 11, 2022

This PR is the first of a series of PRs to support exec.d across libcnb.

Changes libcnb-cargo and libcnb-test to package all binaries of a buildpack crate into the final buildpack. Previously, a buildpack crate could only contain one binary target. Allowing multiple binaries enables use-cases like exec.d binaries written in Rust that exist in the buildpack that uses them. These binaries will be packaged into .libcnb-cargo/additional-bin/$TARGET_NAME.

An additional PR that is coming soon will make it easier to reference these binaries via macros at build time.

Closes GUS-W-10670969

@Malax Malax force-pushed the malax/build-all-binaries branch 8 times, most recently from b57a480 to bb29cf8 Compare February 11, 2022 15:10
@Malax Malax changed the title Package all binary targets into buildpack Package all binary targets Feb 11, 2022
@Malax Malax marked this pull request as ready for review February 11, 2022 15:21
@Malax Malax requested review from edmorley and schneems February 11, 2022 15:21
@Malax Malax force-pushed the malax/build-all-binaries branch from bb0985f to a0ae475 Compare February 11, 2022 16:10
Malax and others added 5 commits February 14, 2022 09:36
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
@Malax Malax force-pushed the malax/build-all-binaries branch from d08a9df to 53c43de Compare February 14, 2022 08:37
@Malax Malax requested a review from edmorley February 14, 2022 08:45
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thank you :-)

@Malax Malax merged commit 4675daf into main Feb 14, 2022
@Malax Malax deleted the malax/build-all-binaries branch February 14, 2022 14:28
@Malax Malax added this to the libcnb 0.6.0 milestone Feb 16, 2022
@Malax Malax mentioned this pull request Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants