Skip to content

Commit

Permalink
Switch to the recommended regional S3 domain (#400)
Browse files Browse the repository at this point in the history
Whilst the global S3 endpoint (`s3.amazonaws.com`) still works,
AWS now recommends using the appropriate regional endpoint
to access the bucket:
https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html#s3-legacy-endpoints

The example Ruby buildpack's bucket is in `us-east-1`, whose regional domain
is `*.s3.us-east-1.amazonaws.com`:
https://docs.aws.amazon.com/general/latest/gr/s3.html#s3_region

GUS-W-11283397.
  • Loading branch information
edmorley authored Jun 13, 2022
1 parent b5d4d87 commit e4e75c4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion examples/ruby-sample/buildpack.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ name = "Example libcnb buildpack: ruby"
id = "heroku-20"

[metadata]
ruby_url = "https://heroku-buildpack-ruby.s3.amazonaws.com/heroku-20/ruby-2.7.4.tgz"
ruby_url = "https://heroku-buildpack-ruby.s3.us-east-1.amazonaws.com/heroku-20/ruby-2.7.4.tgz"

0 comments on commit e4e75c4

Please sign in to comment.