Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added selective environment passing for VM. #890

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Added selective environment passing for VM. #890

merged 1 commit into from
Feb 5, 2025

Conversation

jounathaen
Copy link
Member

Invocation: uhyve -e HOST=myhost -e "ASDF=lkj" mykernel.

@jounathaen jounathaen force-pushed the env_var branch 2 times, most recently from 7753a08 to 1320ef9 Compare February 3, 2025 11:25
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 56.45161% with 27 lines in your changes missing coverage. Please review.

Project coverage is 70.07%. Comparing base (08a6e75) to head (0bfe983).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/hypercall.rs 0.00% 16 Missing ⚠️
src/linux/x86_64/kvm_cpu.rs 0.00% 5 Missing ⚠️
src/bin/uhyve.rs 0.00% 3 Missing ⚠️
src/params.rs 91.17% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #890      +/-   ##
==========================================
- Coverage   70.16%   70.07%   -0.10%     
==========================================
  Files          24       24              
  Lines        2963     3014      +51     
==========================================
+ Hits         2079     2112      +33     
- Misses        884      902      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jounathaen jounathaen force-pushed the env_var branch 2 times, most recently from 53a1061 to ee54f91 Compare February 3, 2025 15:49
Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, but I have a few suggestions and questions. :)

@jounathaen jounathaen force-pushed the env_var branch 4 times, most recently from c47cd15 to f511e19 Compare February 3, 2025 19:31
@jounathaen jounathaen dismissed mkroening’s stale review February 5, 2025 09:50

All changes implemented

@jounathaen jounathaen added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit 0bfe983 Feb 5, 2025
19 checks passed
@jounathaen jounathaen deleted the env_var branch February 5, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants