-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: encoder pro max #37
Conversation
…onvention. Also, removed preview_ready event
For the macOS encoder, we can use my https://github.com/clearlysid/bh-encode/tree/main as a reference point for testing. Currently the problem is that I have only created the encoder for YUVFrames captured in Mac. However, for Micro's usecase Gifski will prefer to have BGRA (i think, need to confirm). The encoder will not work until we support that format also. This PR cannot be merged to main until that feature is complete. |
atleast it is fast 😂 |
It is resolved on my machine, yup. Changed For eg: in @anubhavitis's machine it was working properly even before I made the stride fix. Does that mean his version would be broken now? 🤔 |
We can get on a call to debug this if this doesn't work. Again, if it's working no need to touch it. But if we encounter errors, I'll be happy to help. I'll also test it out with different values. |
This PR is a big one. It gets rid of FFmpeg in favour of OS-based encoders for the preview generation. This makes our binary even smaller, and makes the distribution and bundling proceses easier. Under the hood, It uses a custom Swift package for macOS and windows-capture encoder for Windows
TODOs: