Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[helm/charts] [stakater/reloader] Add reloader to helm public charts repo #9859

Merged
merged 10 commits into from
Feb 15, 2019
Merged

[helm/charts] [stakater/reloader] Add reloader to helm public charts repo #9859

merged 10 commits into from
Feb 15, 2019

Conversation

faizanahmad055
Copy link
Collaborator

Signed-off-by: Faizan Ahmad
username: faizanahmad055
email: faizan.ahmad55@outlook.com

What this PR does / why we need it:

  • Reloader an opensource tool maintained by Stakater
  • Reloader is a Kubernetes controller to watch changes in ConfigMap and Secrets and then restart pods for Deployment, StatefulSet, and DaemonSet

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@helm-bot helm-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 10, 2018
@faizanahmad055
Update reloader deploymentapiVersion
988a09f 
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 10, 2018
@faizanahmad055
Update chart.yaml
e22be0d 
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
@helm-bot helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 10, 2018
@faizanahmad055
Fix selector labels
6be0eb5 
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
@helm-bot helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 11, 2018
@faizanahmad055
Copy link
Collaborator Author

Hi @cpanato
Ping

cpanato
cpanato reviewed Dec 12, 2018
View reviewed changes
@cpanato
Copy link
Member

cpanato commented Dec 12, 2018

just a small, otherwise lgtm

@cpanato
Copy link
Member

cpanato commented Dec 12, 2018

can I have your eyes here as well @davidkarlsen ?

@faizanahmad055
Update chart version
3b0197f 
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
@helm-bot helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 12, 2018
@faizanahmad055
Update sources
4977ac6 
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
@helm-bot helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 12, 2018
cpanato
cpanato approved these changes Dec 12, 2018
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks!

@faizanahmad055
Update readme
1d8fe75 
Signed-off-by: faizanahmad055 <faizan.ahmad55@outlook.com>
@helm-bot helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 13, 2018
@faizanahmad055
Copy link
Collaborator Author

Hi @davidkarlsen, @foxish, @seanknox
Ping

1 similar comment
@faizanahmad055
Copy link
Collaborator Author

Hi @davidkarlsen, @foxish, @seanknox
Ping

@faizanahmad055
Copy link
Collaborator Author

Hi @davidkarlsen, @foxish, @seanknox
Can you guys take a look? All requested changes have been implemented.

@faizanahmad055
Copy link
Collaborator Author

Hi @davidkarlsen, @foxish, @seanknox, @cpanato
Can you guys take a look? This is a very useful tool. All change requests have been implemented. I think you just need to merge it.

@faizanahmad055
Copy link
Collaborator Author

Hi @davidkarlsen, @foxish, @seanknox, @cpanato
Ping

@faizanahmad055
Copy link
Collaborator Author

Hi @davidkarlsen, @foxish, @seanknox, @cpanato
Any update on this, please?

@stale
Copy link

stale bot commented Feb 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 7, 2019
@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 15, 2019
@cpanato
Copy link
Member

cpanato commented Feb 15, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, faizanahmad055

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 5de8d5f into helm:master Feb 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cpanato cpanato cpanato approved these changes

@foxish foxish Awaiting requested review from foxish

@seanknox seanknox Awaiting requested review from seanknox

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@faizanahmad055 @cpanato @k8s-ci-robot @helm-bot @waseem-h