-
Notifications
You must be signed in to change notification settings - Fork 16.7k
Conversation
/assign @mattfarina |
I was literally writing a chart for that this weekend. Glad to see someone else took an interest too. |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting the pull request. I know of several people who want to use nextcloud on Kubernetes. This is great.
I did a quick review to provide some feedback.
incubator/nextcloud/Chart.yaml
Outdated
sources: | ||
- https://github.com/nextcloud/server | ||
maintainers: | ||
- name: Keiran Smith |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name should be your github username. That helps us to know who to contact when there's an issue with the chart.
incubator/nextcloud/OWNERS
Outdated
- tompizmor | ||
- sameersbn | ||
- carrodher | ||
- affix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the time you can drop this file. It looks like you copied this from a chart managed by Bitnami. Since you're not a member of the Kubernetes org at the moment this isn't going to enable you to review or merge for the chart. Once you have some more contributions you can apply for membership and then a file like this will make sense.
incubator/nextcloud/values.yaml
Outdated
resources: | ||
requests: | ||
memory: 512Mi | ||
cpu: 300m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is generally not advisable to provide hard resource limits to workloads and leave it configurable unless the workload requires such quantity bare minimum to function.
This is from the reviewers guide.
Can you comment these out unless this is the minimum to function.
incubator/nextcloud/values.yaml
Outdated
## | ||
ingress: | ||
enabled: false | ||
servicePort: 80 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the container image allow for both http and https? It might be nice to allow for secure out of the box. That doesn't need to be part of the first PR but would be nice to add.
incubator/nextcloud/values.yaml
Outdated
image: | ||
registry: docker.io | ||
repository: nextcloud | ||
tag: latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the image information to follow our standard layout? See the guide for more information and an example.
Also, please use a tagged version rather than latest. This will enable consistency between environments.
@@ -0,0 +1,28 @@ | |||
{{- if .Values.ingress.enabled }} | |||
apiVersion: {{ required "A valid .Values.networkPolicyApiVersion entry required!" .Values.networkPolicyApiVersion }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the API version a values parameter?
@@ -0,0 +1,103 @@ | |||
{{- if include "nextcloud.host" . -}} | |||
apiVersion: extensions/v1beta1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use the apps/v1beta2
version instead?
@@ -0,0 +1,5 @@ | |||
dependencies: | |||
- name: mariadb | |||
version: 0.7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version supports ranges. What about ~0.7.0
so that it can pull in patch level differences?
Please compare with what you get from |
I think it would make more sense to PR against Also I can help maintain this chart. Another question: how could we keep this under |
@affix are you still planning to finish this? I was about to write a chart for nextcloud as well, but will wait for this to complete - unless you want someone else to pick up where you left off? |
@billimek I am planning to, just been a hectic few weeks. I will get it sorted and address comments |
- Change maintainer to affix - Remove OWNERS file - Comment out resources in values.yml - Default to nextcloud 13.0.4-apache - Specify Ingress api version - Make Deployment v1beta2 - Support patch level MariaDB Signed-off-by: Keiran Smith <contact@keiran.scot>
@mattfarina I have made the comments you requested |
- Change maintainer to affix - Remove OWNERS file - Comment out resources in values.yml - Default to nextcloud 13.0.4-apache - Specify Ingress api version - Make Deployment v1beta2 - Support patch level MariaDB Signed-off-by: Keiran Smith <contact@keiran.scot>
Signed-off-by: Keiran Smith <contact@keiran.scot>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, please compare with what you get from helm create using Helm 2.8+ and update accordingly (_helpers.tpl
, standard labels, etc.).
Also, you'll need to merge in the latest master to make CI happy.
stable/nextcloud/README.md
Outdated
|
||
## Prerequisites | ||
|
||
- Kubernetes 1.4+ with Beta APIs enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be 1.9+
@@ -0,0 +1,103 @@ | |||
{{- if include "nextcloud.host" . -}} | |||
apiVersion: extensions/v1beta1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apps/v1
stable/nextcloud/.helmignore
Outdated
@@ -0,0 +1 @@ | |||
.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use .helmignore
you get from helm create
# - secretName: nextcloud.cluster.local | ||
# hosts: | ||
# - nextcloud.cluster.local | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest you add one level of nesting:
nextcloud:
host:
loadBalancerIP:
username:
password:
...
In the
... however it doesn't appear that anything is referencing these values. From what I gather, this should be referencing where the nextcloud data itself resides. Perhaps the following should be added: in
(see new references to A new file,
Also suggest moving the |
@affix Just FYI, |
The following also needs to change in order for the nextcloud autoconfiguration to work properly,
should be:
|
affix#1 created with the changes I suggested. Also added the ability to set existing claims for use in NextCloud via the 'external storage' plugin. |
Oh, I see what you are saying. Well, for development purposes you could have "drop" commits that only bump the version number. Once you are confident with the PR and everything has been addressed, just drop those. Not sure if this is the right workflow in |
Is there anything we are waiting on to merge this one? |
@@ -0,0 +1,19 @@ | |||
name: nextcloud | |||
version: 0.1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So apparently, charts going to stable need to start at 1.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version: 0.1.1 | |
version: 1.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so the bitnami docker image is gone, as others have noted here. i've tried to fix all the 404s refering to that image and point instead at the official docker image managed by the nextcloud organization. i am not sure it's sufficient here because the newer image might not work the same way esp. WRT the mariadb bitnami image.
@@ -0,0 +1,128 @@ | |||
# nextcloud | |||
|
|||
[nextcloud](https://nextcloud.org/) is a file sharing server that puts the control and security of your own data back into your hands. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
making this formal with GH's new proposed change gizmo:
[nextcloud](https://nextcloud.org/) is a file sharing server that puts the control and security of your own data back into your hands. | |
[nextcloud](https://nextcloud.com/) is a file sharing server that puts the control and security of your own data back into your hands. |
@@ -0,0 +1,170 @@ | |||
## Bitnami nextcloud image version | |||
## ref: https://hub.docker.com/r/bitnami/nextcloud/tags/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## ref: https://hub.docker.com/r/bitnami/nextcloud/tags/ | |
## Official nextcloud image version | |
## ref: https://hub.docker.com/r/library/nextcloud/tags/ |
email: user@example.com | ||
|
||
## Set to `yes` to allow the container to be started with blank passwords | ||
## ref: https://github.com/bitnami/bitnami-docker-nextcloud#environment-variables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## ref: https://github.com/bitnami/bitnami-docker-nextcloud#environment-variables | |
## ref: https://github.com/nextcloud/docker#auto-configuration-via-environment-variables |
enabled: true | ||
|
||
## Create a database | ||
## ref: https://github.com/bitnami/bitnami-docker-mariadb/blob/master/README.md#creating-a-database-on-first-run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another broken link:
## ref: https://github.com/bitnami/bitnami-docker-mariadb/blob/master/README.md#creating-a-database-on-first-run | |
## ref: https://github.com/nextcloud/docker#using-an-external-database |
mariadbDatabase: nextcloud | ||
|
||
## Create a database user | ||
## ref: https://github.com/bitnami/bitnami-docker-mariadb/blob/master/README.md#creating-a-database-user-on-first-run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just remove this duplicate link
## ref: https://github.com/bitnami/bitnami-docker-mariadb/blob/master/README.md#creating-a-database-user-on-first-run |
mariadbUser: nextcloud | ||
|
||
## Password for mariadbUser | ||
## ref: https://github.com/bitnami/bitnami-docker-mariadb/blob/master/README.md#creating-a-database-user-on-first-run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just remove this duplicate link
## ref: https://github.com/bitnami/bitnami-docker-mariadb/blob/master/README.md#creating-a-database-user-on-first-run |
# mariadbPassword: | ||
|
||
## MariaDB admin password | ||
## ref: https://github.com/bitnami/bitnami-docker-mariadb/blob/master/README.md#setting-the-root-password-on-first-run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just remove this duplicate link
## ref: https://github.com/bitnami/bitnami-docker-mariadb/blob/master/README.md#setting-the-root-password-on-first-run |
Hej, what's the state of this ? Would be great to have it meged soon! |
FYI the official nextcloud docker image lacks php-imap support because a maintainer deemed it to be "too big". This makes it useless for my setup, even if the helm chart works. :'( |
On 2018-11-22 05:12:51, Martyn Ranyard wrote:
FYI the official nextcloud docker image lacks php-imap support because a maintainer deemed it to be "too big". This makes it useless for my setup, even if the helm chart works. :'(
Well we have to stat somewhere. There can be a billion variations for
any PHP-hosted project but hopefully the chart would serve as a good
foundation for any of those...
|
Any updates? |
+1 on getting this merged |
Pretty please? |
If we can get something merged, then it will be easier for people to contribute bugfixes/features. |
perhaps @affix abandoned this PR? What is left from @unguiculus review that is undone? I agree with @kfox1111 let's wrap this up and get it merged so it can get some wider testing and then new PRs. |
Also interested in this chart. I think it is reasonable to merge this to incubating so then interested people can contribute fixes |
@@ -0,0 +1,19 @@ | |||
name: nextcloud | |||
version: 0.1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version: 0.1.1 | |
version: 1.0.0 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: affix If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
if someone is really interested in getting this off the ground, the way forward is to just make a new PR, because the proposed changes here do not seem to be going anywhere... |
/assign @mattfarina |
Came looking for a Nextcloud chart and found this PR. I see a few things haven't been fixed from the changes requested. I'd fix it, but am still learning. Hope it's still being actively worked on. PS: The |
Hey together, |
Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com>
I'm looking forward to this getting merged. |
I'd suggest we move forward with #10922. |
* add nextcloud chart Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com> * insert suggestions from reviews in #5180 Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com> * disable ingress per default Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com> * fix nextcloud e2e tests Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com>
Closing in favor of #10922. |
* add nextcloud chart Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com> * insert suggestions from reviews in #5180 Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com> * disable ingress per default Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com> * fix nextcloud e2e tests Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com> * [nextcloud] add owners file for further contribution Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com>
* add nextcloud chart Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com> * insert suggestions from reviews in helm#5180 Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com> * disable ingress per default Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com> * fix nextcloud e2e tests Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com>
* add nextcloud chart Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com> * insert suggestions from reviews in helm#5180 Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com> * disable ingress per default Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com> * fix nextcloud e2e tests Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com> * [nextcloud] add owners file for further contribution Signed-off-by: Christian Ingenhaag <christian.ingenhaag@googlemail.com>
What this PR does / why we need it:
This PR adds a nextcloud chart to incubator
Nextcloud offers industry-leading on-premises file sync and online collaboration technology. Our expertise is in combining the convenience and ease of use of consumer-grade solutions like Dropbox and Google Drive with the security, privacy and control business needs.
Special notes for your reviewer:
This is loosely based around the owncloud chart, However I as many other prefer to use nextcloud for some of its optimisations.
Uses the official Nextcloud Docker image