Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/apm-server] add @mumoshu to OWNERS #12066

Merged

Conversation

mumoshu
Copy link
Collaborator

@mumoshu mumoshu commented Mar 11, 2019

As I am the original author of the chart. Currently I miss the privilege to put LGTM any pull rquest to chart due to the situation, as seen in #11661 (comment)

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 11, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @mumoshu. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 11, 2019
@mumoshu mumoshu force-pushed the add-mumoshu-as-stable-apm-server-owner branch from 86b9233 to 1a007fc Compare March 21, 2019 12:48
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 21, 2019
@mumoshu
Copy link
Collaborator Author

mumoshu commented Mar 21, 2019

@mattfarina Would you mind approving this? Without this, I can't put LGTM on the chart I created 😅

@mumoshu
Copy link
Collaborator Author

mumoshu commented Mar 21, 2019

/assign @mattfarina

@cpanato
Copy link
Member

cpanato commented Mar 24, 2019

@mumoshu please bump the chart version

@mumoshu mumoshu force-pushed the add-mumoshu-as-stable-apm-server-owner branch from 1a007fc to cc71627 Compare March 25, 2019 01:29
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2019
As I am the original author of the chart. Currently I miss the privilege to put LGTM any pull rquest to chart due to the situation, as seen in helm#11661 (comment)

Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
@mumoshu mumoshu force-pushed the add-mumoshu-as-stable-apm-server-owner branch from cc71627 to f2658dd Compare March 25, 2019 01:30
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2019
@mumoshu
Copy link
Collaborator Author

mumoshu commented Mar 25, 2019

@cpanato Thanks for reviewing! Just bumped the version num.

@cpanato
Copy link
Member

cpanato commented Mar 26, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 26, 2019
@mattfarina
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattfarina, mumoshu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6d33cac into helm:master Apr 15, 2019
TsuyoshiUshio pushed a commit to TsuyoshiUshio/charts that referenced this pull request Apr 18, 2019
As I am the original author of the chart. Currently I miss the privilege to put LGTM any pull rquest to chart due to the situation, as seen in helm#11661 (comment)

Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
hajnej pushed a commit to hajnej/charts that referenced this pull request Apr 24, 2019
As I am the original author of the chart. Currently I miss the privilege to put LGTM any pull rquest to chart due to the situation, as seen in helm#11661 (comment)

Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
devnulled pushed a commit to devnulled/charts that referenced this pull request Apr 25, 2019
As I am the original author of the chart. Currently I miss the privilege to put LGTM any pull rquest to chart due to the situation, as seen in helm#11661 (comment)

Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
dermorz pushed a commit to dermorz/charts that referenced this pull request Apr 26, 2019
As I am the original author of the chart. Currently I miss the privilege to put LGTM any pull rquest to chart due to the situation, as seen in helm#11661 (comment)

Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
dpkirchner pushed a commit to dpkirchner/charts that referenced this pull request May 9, 2019
As I am the original author of the chart. Currently I miss the privilege to put LGTM any pull rquest to chart due to the situation, as seen in helm#11661 (comment)

Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
goshlanguage pushed a commit to goshlanguage/charts that referenced this pull request May 17, 2019
As I am the original author of the chart. Currently I miss the privilege to put LGTM any pull rquest to chart due to the situation, as seen in helm#11661 (comment)

Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
As I am the original author of the chart. Currently I miss the privilege to put LGTM any pull rquest to chart due to the situation, as seen in helm#11661 (comment)

Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants