Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

Added custom labels on jenkins ingress #11466

Merged

Conversation

wjeanneau
Copy link
Contributor

Signed-off-by: wjeanneau william.jeanneau@gmail.com

What this PR does / why we need it:

Implement custom labels for ingress

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • [x ] DCO signed
  • [x ] Chart Version bumped
  • [x ] Variables are documented in the README.md

Signed-off-by: wjeanneau <william.jeanneau@gmail.com>
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Feb 16, 2019
@wjeanneau
Copy link
Contributor Author

/assign @maorfr

@maorfr
Copy link
Member

maorfr commented Feb 17, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maorfr, wjeanneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit c875d2b into helm:master Feb 17, 2019
@wjeanneau wjeanneau deleted the feature/jenkins_add_ingress_custom_labels branch February 17, 2019 03:20
gandazgul pushed a commit to gandazgul/charts that referenced this pull request Feb 18, 2019
Signed-off-by: wjeanneau <william.jeanneau@gmail.com>
Signed-off-by: Carlos Ravelo <ravelo.carlos@gmail.com>
wmcdona89 pushed a commit to wmcdona89/charts that referenced this pull request Aug 30, 2020
Signed-off-by: wjeanneau <william.jeanneau@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants