Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometheus-operator] Add vsliouniaev to approvers, reviewers #11443

Merged
merged 2 commits into from
Feb 15, 2019
Merged

[stable/prometheus-operator] Add vsliouniaev to approvers, reviewers #11443

merged 2 commits into from
Feb 15, 2019

Conversation

vsliouniaev
Copy link
Collaborator

@vsliouniaev vsliouniaev commented Feb 15, 2019 •
edited
Loading

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart version bumped

@vsliouniaev
Add vsliouniaev to approvers, reviewers
ed8992a 
Signed-off-by: Vasily <vasily.sliouniaev@jet.com>
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Feb 15, 2019
@vsliouniaev
Bump chart vers
f26f3c1 
Seems strange, to have to bump for things in the ignore file

Signed-off-by: Vasily <vasily.sliouniaev@jet.com>
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 15, 2019
@gianrubio
Copy link
Collaborator

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. labels Feb 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gianrubio, vsliouniaev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit cec86f6 into helm:master Feb 15, 2019
@vsliouniaev vsliouniaev deleted the add-vsliouniaev branch February 15, 2019 11:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gianrubio gianrubio Awaiting requested review from gianrubio

@sameersbn sameersbn Awaiting requested review from sameersbn

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vsliouniaev @gianrubio @k8s-ci-robot @helm-bot