Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/jenkins] fix 11412 jenkins sidecars #11413

Merged
merged 2 commits into from
Feb 14, 2019

Conversation

torstenwalter
Copy link
Collaborator

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@helm-bot helm-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 14, 2019
@torstenwalter torstenwalter changed the title Fix 11412 jenkins sidecars [stable/jenkins] fix 11412 jenkins sidecars Feb 14, 2019
- moved Master.Sidecars.other to correct location
- added documentation for Master.JCasC.enabled
- made 'jenkins' the primary container again
- bumped chart version
- replaced tabs with spaces in README

Signed-off-by: Torsten Walter <mail@torstenwalter.de>
@torstenwalter torstenwalter force-pushed the fix-11412-jenkins-sidecars branch from 6edce89 to 500f451 Compare February 14, 2019 11:45
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 14, 2019
@lachie83
Copy link
Contributor

/ok-to-test

@helm-bot helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 14, 2019
@lachie83
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lachie83, torstenwalter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 14, 2019
@k8s-ci-robot k8s-ci-robot merged commit 362b4ce into helm:master Feb 14, 2019
@torstenwalter torstenwalter deleted the fix-11412-jenkins-sidecars branch April 1, 2019 12:00
wmcdona89 pushed a commit to wmcdona89/charts that referenced this pull request Aug 30, 2020
- moved Master.Sidecars.other to correct location
- added documentation for Master.JCasC.enabled
- made 'jenkins' the primary container again
- bumped chart version
- replaced tabs with spaces in README

Signed-off-by: Torsten Walter <mail@torstenwalter.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[stable/jenkins] Master.Sidecars.other and Master.JCasC.enabled do not work in combination
4 participants