This repository was archived by the owner on Feb 22, 2022. It is now read-only.
[stable/atlantis] fix naming for secret ref #11379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
the
size/XS
|
@etwillbefine please bump the chart version and sign the DCO |
etwillbefine
changed the title
helm-bot
added
Contribution Allowed
the secret will be named according to the `.fullName`. Currently the pod cant start with the error "secrets-webhook" not found. It must be "my-full-atlantis-name-webhook" Signed-off-by: Tim Gatzemeier <etwillbefine@users.noreply.github.com>
helm-bot
added
size/XS
Signed-off-by: Tim Gatzemeier <tgatzemeier@testo.de>
helm-bot
added
Contribution Allowed
|
/ok-to-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, etwillbefine The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
tbuchier
pushed a commit
to tbuchier/charts
that referenced
this pull request
Feb 14, 2019
* fix naming for secret ref the secret will be named according to the `.fullName`. Currently the pod cant start with the error "secrets-webhook" not found. It must be "my-full-atlantis-name-webhook" Signed-off-by: Tim Gatzemeier <etwillbefine@users.noreply.github.com> * update chart version for atlantis to 1.1.5 Signed-off-by: Tim Gatzemeier <tgatzemeier@testo.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the secret will be named according to the
.fullName. Currently the pod cant start with the error "secrets-webhook" not found. It must be "my-full-atlantis-name-webhook"What this PR does / why we need it:
Fixing include of gitlab token from
-webhooksecretWhich issue this PR fixes
Special notes for your reviewer:
Checklist