Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

Added values to chose init container, additional label for Ingress and deleteDefaultPlugins option. #11361

Merged
merged 9 commits into from
Feb 15, 2019
Merged

Added values to chose init container, additional label for Ingress and deleteDefaultPlugins option. #11361

merged 9 commits into from
Feb 15, 2019

Conversation

andreyshamray
Copy link
Contributor

What this PR does / why we need it:

I have added several values which will improve the flexibility, security and upgrade plugins procedure of this chart.

  1. ingress.labels - will give you an opportunity to route traffic to particular Ingress controller.
  2. plugins.initContainerImage - it is needed for security reason, for example, access to docker hub is not permitted.
  3. plugins.deleteDefaultPlugins - this option will remove default plugins and deploy plugins from plugins.install list. It will give an opportunity to upgrade plugins.

@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 12, 2019
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 12, 2019
added new values
bbb5c8c 
Signed-off-by: Andriy Shamray <andriy.shamray@intapp.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 12, 2019
chaged ingress.labels in values.yaml
df4945e 
Signed-off-by: Andriy Shamray <andriy.shamray@intapp.com>
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 12, 2019
@andreyshamray
Copy link
Contributor Author

/assign @rjkernick

@andreyshamray
Copy link
Contributor Author

Hi, guys will be good if you can merge it, so I will no need to store this chart in local helm repo.
Thanks in advance.

@rjkernick
Copy link
Collaborator

/ok-to-test

rjkernick
rjkernick suggested changes Feb 13, 2019
View reviewed changes
applied PR changes
5c04801 
Signed-off-by: Andriy Shamray <andriy.shamray@intapp.com>
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 14, 2019
@andreyshamray
Copy link
Contributor Author

I have applied all the recommendations.
Thanks!

@andreyshamray
Copy link
Contributor Author

/retest

applied PR changes
3a65024 
Signed-off-by: Andriy Shamray <andriy.shamray@intapp.com>
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 14, 2019
@andreyshamray
Copy link
Contributor Author

/retest

applied PR changes
acfb9ad 
Signed-off-by: Andriy Shamray <andriy.shamray@intapp.com>
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 14, 2019
@andreyshamray
Copy link
Contributor Author

/retest

@rjkernick
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Feb 14, 2019
@rjkernick
Copy link
Collaborator

Please merge the latest master and update the chart.yaml. Please be sure to include "--signoff" when merging. Another pull request got merged ahead of yours

Andriy Shamray added 4 commits February 14, 2019 21:34
changed chart version
c218ec1 
Signed-off-by: Andriy Shamray <andriy.shamray@intapp.com>
fix conflict
1b80d28 
Signed-off-by: Andriy Shamray <andriy.shamray@intapp.com>
Merge branch 'master' of https://github.com/helm/charts
d319759 
PR: Added values to chose init container, additional label for Ingress and deleteDefaultPlugins option

Signed-off-by: Andriy Shamray <andriy.shamray@intapp.com>
changed version: 0.14.0 in Chart.yaml
aa38e6f 
Signed-off-by: Andriy Shamray <andriy.shamray@intapp.com>
@helm-bot helm-bot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 14, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2019
@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 14, 2019
@andreyshamray
Copy link
Contributor Author

andreyshamray commented Feb 14, 2019 •
edited
Loading

Please merge the latest master and update the chart.yaml. Please be sure to include "--signoff" when merging. Another pull request got merged ahead of yours

Hi @rjkernick, all Done!)

@rjkernick
Copy link
Collaborator

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyshamray, rjkernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 40208fd into helm:master Feb 15, 2019
@andreyshamray
Copy link
Contributor Author

Thanks a lot!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rjkernick rjkernick rjkernick requested changes

@foxish foxish Awaiting requested review from foxish

Assignees

@rjkernick rjkernick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreyshamray @rjkernick @k8s-ci-robot @helm-bot