Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

Implements #11353 : [stable/airflow] install-requirements.sh script s… #11357

Merged
merged 3 commits into from
Feb 12, 2019
Merged

Implements #11353 : [stable/airflow] install-requirements.sh script s… #11357

merged 3 commits into from
Feb 12, 2019

Conversation

mgaggero
Copy link
Contributor

…hould be always available

What this PR does / why we need it:

Scripts volume is mounted even if persistence is enabled so install-requirements.sh script is always available,

Which issue this PR fixes

@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 12, 2019
@mgaggero mgaggero force-pushed the airflowscriptsalways branch from 49ff84a to 2cb3db9 Compare February 12, 2019 15:48
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 12, 2019
@mgaggero
Copy link
Contributor Author

/assign @gsemet

@k8s-ci-robot
Copy link
Contributor

@mgaggero: GitHub didn't allow me to assign the following users: gsemet.

Note that only helm members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @gsemet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gsemet
Copy link
Contributor

gsemet commented Feb 12, 2019

/lgtm

/assign maver1ck

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 12, 2019
@gsemet
Copy link
Contributor

gsemet commented Feb 12, 2019

Hi. Can you bump the version to 0.17.1?

@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 12, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2019
@mgaggero mgaggero force-pushed the airflowscriptsalways branch from ccb8696 to a7a41db Compare February 12, 2019 15:59
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 12, 2019
@mgaggero
Copy link
Contributor Author

Hi. Can you bump the version to 0.17.1?

Ok, done.

@mgaggero
Copy link
Contributor Author

@gsemet it seems that it needs the lgtm label to continue with the checks.

@gsemet
Copy link
Contributor

gsemet commented Feb 12, 2019

/lgtm

there is another PR #11358 ongoing, which one will be merged first :)

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2019
@gsemet
Copy link
Contributor

gsemet commented Feb 12, 2019

:) can you rebase and dump to 0.17.2 ?

@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2019
@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 12, 2019
@mgaggero mgaggero force-pushed the airflowscriptsalways branch from 77fa340 to 981affa Compare February 12, 2019 16:44
@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 12, 2019
@mgaggero
Implements helm#11353 : [stable/airflow] install-requirements.sh scri…
596ae61 
…pt should be always available

Signed-off-by: Massimo Gaggero <massimo.gaggero@crs4.it>
@mgaggero
- fixes scripts volume creation issue
6987685 
Signed-off-by: Massimo Gaggero <massimo.gaggero@crs4.it>
@mgaggero
- updates version
a4f5146 
Signed-off-by: Massimo Gaggero <massimo.gaggero@crs4.it>
@mgaggero mgaggero force-pushed the airflowscriptsalways branch from 981affa to a4f5146 Compare February 12, 2019 16:46
@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 12, 2019
@mgaggero
Copy link
Contributor Author

:) can you rebase and dump to 0.17.2 ?

Done, needs lgtm label again :)

@maver1ck
Copy link
Collaborator

/ok-to-test

@gsemet
Copy link
Contributor

gsemet commented Feb 12, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gsemet, mgaggero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit e0119b6 into helm:master Feb 12, 2019
tbuchier pushed a commit to tbuchier/charts that referenced this pull request Feb 14, 2019
@mgaggero @tbuchier
Implements helm#11353 : [stable/airflow] install-requirements.sh scri…
d6a88d3 
…pt s… (helm#11357)

* Implements helm#11353 : [stable/airflow] install-requirements.sh script should be always available

Signed-off-by: Massimo Gaggero <massimo.gaggero@crs4.it>

* - fixes scripts volume creation issue

Signed-off-by: Massimo Gaggero <massimo.gaggero@crs4.it>

* - updates version

Signed-off-by: Massimo Gaggero <massimo.gaggero@crs4.it>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maver1ck maver1ck Awaiting requested review from maver1ck

Assignees

@maver1ck maver1ck

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[stable/airflow] install-requirements.sh script should be always available
5 participants
@mgaggero @k8s-ci-robot @gsemet @maver1ck @helm-bot