This repository was archived by the owner on Feb 22, 2022. It is now read-only.
[stable/jenkins] merge sidecard configs #11339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- renamed Sidecar to Sidecars - moved image, pullPolicy and resources below configAutoReload - renamed SidecarContainers to Master.Sidecars.other - increased chart version Signed-off-by: Torsten Walter <mail@torstenwalter.de>
helm-bot
added
Contribution Allowed
|
LGTM @torstenwalter, nice work. No problems according to my testing. Thanks for this. |
|
/assign |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maorfr, torstenwalter The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
tbuchier
pushed a commit
to tbuchier/charts
that referenced
this pull request
Feb 14, 2019
- renamed Sidecar to Sidecars - moved image, pullPolicy and resources below configAutoReload - renamed SidecarContainers to Master.Sidecars.other - increased chart version Signed-off-by: Torsten Walter <mail@torstenwalter.de>
wmcdona89
pushed a commit
to wmcdona89/charts
that referenced
this pull request
Aug 30, 2020
- renamed Sidecar to Sidecars - moved image, pullPolicy and resources below configAutoReload - renamed SidecarContainers to Master.Sidecars.other - increased chart version Signed-off-by: Torsten Walter <mail@torstenwalter.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Torsten Walter mail@torstenwalter.de
What this PR does / why we need it:
It consolidates the sidecar configurations for Jenkins.
Which issue this PR fixes
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]