Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/concourse] Remove duplicate line #11322

Merged
merged 1 commit into from
Feb 12, 2019
Merged

[stable/concourse] Remove duplicate line #11322

merged 1 commit into from
Feb 12, 2019

Conversation

bracki
Copy link
Contributor

@bracki bracki commented Feb 11, 2019

@cirocosta Remove a duplicate line.

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 11, 2019
@bracki bracki changed the title Remove duplicate line [stable/concourse] Remove duplicate line Feb 11, 2019
@cirocosta
Copy link
Collaborator

oooh, thxx!!

@cirocosta
Copy link
Collaborator

/ok-to-test

cirocosta
cirocosta suggested changes Feb 11, 2019
View reviewed changes
Copy link
Collaborator

@cirocosta cirocosta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite being a minor patch, it'd be necessary to have the version at Chart.yaml bumped 👍

@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 11, 2019
@bracki
Copy link
Contributor Author

bracki commented Feb 11, 2019

@cirocosta Bumped the chart version as requested.

@cirocosta
Copy link
Collaborator

Thanks!

Now the only thing missing is applying the Signed-of-by trailer to your commit (so that the DCO bot gets happy) - https://github.com/helm/charts/blob/master/CONTRIBUTING.md#sign-your-work.

Thanks!

@bracki
Remove duplicate line
746016e 
Signed-off-by: Jan Brauer <jan.brauer@superluminar.io>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 12, 2019
@bracki
Copy link
Contributor Author

bracki commented Feb 12, 2019

@cirocosta Done!

@cirocosta
Copy link
Collaborator

Awesome! Thx!

@cirocosta
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bracki, cirocosta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4df52d5 into helm:master Feb 12, 2019
tbuchier pushed a commit to tbuchier/charts that referenced this pull request Feb 14, 2019
@bracki @tbuchier
Remove duplicate line (helm#11322)
400e57e 
Signed-off-by: Jan Brauer <jan.brauer@superluminar.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cirocosta cirocosta cirocosta requested changes

@william-tran william-tran Awaiting requested review from william-tran

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bracki @cirocosta @k8s-ci-robot @helm-bot