[stable/datadog] Adjust release naming in helpers

[naseemkullah]

What this PR does / why we need it:

Modernizing the templates file to match newer charts. What this allows is that if one wants to include datadog in the release name, one gets more desirable object names e.g. no datadog-datadog but rather simply datadog (once).

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• DCO signed
• Chart Version bumped
• Variables are documented in the README.md

[k8s-ci-robot]

Hi @naseemkullah. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[naseemkullah]

cc @hkaj @irabinovitch @xvello @CharlyF

[davidkarlsen]

/ok-to-test
/assign

[davidkarlsen]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidkarlsen, naseemkullah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• stable/datadog/OWNERS [davidkarlsen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[irabinovitch]

@davidkarlsen @naseemkullah Thanks, we'll take a look at this ASAP.

[irabinovitch]

/assign hkaj

[rifelpet]

FYI upgrading through this chart version was not seamless.

With a release name of datadog, this change renamed our DaemonSet from datadog-datadog to datadog. I expected helm to delete the old DS and create the new DS, and the new pods may fail on startup due to port binding collisions with hostNetwork: true, but what actually occurred was that the new DS had a desired count of 0:

k get daemonsets -o wide
NAME       DESIRED   CURRENT   READY   UP-TO-DATE   AVAILABLE   NODE SELECTOR   AGE    CONTAINERS   IMAGES                                       SELECTOR
datadog    0         0         0       0            0           <none>          5s     datadog      datadog/agent:6.9.0                          app=datadog

No taints or node selectors changed. I had to delete the release and reinstall from scratch in order for the datadog DaemonSet to get the correct desired number of pods.

[naseemkullah]

Thanks @rifelpet and sorry for the inconvenience!

I will follow up with a note in the Upgrading section of the README!

[rifelpet]

No worries, it didn't have a major impact on us and using https://github.com/databus23/helm-diff in our CI pipeline helped us be aware of this ahead of time.

I agree it may be worth mentioning in the readme. Thanks!

[naseemkullah]

#11515 created!

[nickdgriffin]

This just caught us out and did have an impact - it's quite a significant change.

The new "fullnameOverride" value isn't mentioned in the default values file or in the table in the README, either, so it's not obvious that it has been introduced and there's no changelog to review prior to applying.

[naseemkullah]

Thanks for pointing that out @nickdgriffin and my apologies for the inconvenience this may have caused.

#11903 created