This repository was archived by the owner on Feb 22, 2022. It is now read-only.
Added permissions to handle ingress #11177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
the
size/XS
Signed-off-by: Chaoran Yu <yuchaoran2011@gmail.com>
k8s-ci-robot
added
the
approved
yuchaoran2011
force-pushed
the
ingress
branch
from
27c4f95 to
d29dac4
Compare
helm-bot
added
Contribution Allowed
|
/assign @liyinan926 |
cpanato
approved these changes
Feb 6, 2019
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, yuchaoran2011 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
smusali
pushed a commit
to leeliu/charts
that referenced
this pull request
Feb 6, 2019
Signed-off-by: Chaoran Yu <yuchaoran2011@gmail.com> Signed-off-by: Samir Musali <samir.musali@logdna.com>
smusali
pushed a commit
to leeliu/charts
that referenced
this pull request
Feb 6, 2019
Signed-off-by: Chaoran Yu <yuchaoran2011@gmail.com> Signed-off-by: Samir Musali <samir.musali@logdna.com>
smusali
pushed a commit
to leeliu/charts
that referenced
this pull request
Feb 6, 2019
Signed-off-by: Chaoran Yu <yuchaoran2011@gmail.com> Signed-off-by: Samir Musali <samir.musali@logdna.com>
smusali
pushed a commit
to leeliu/charts
that referenced
this pull request
Feb 6, 2019
Signed-off-by: Chaoran Yu <yuchaoran2011@gmail.com> Signed-off-by: Samir Musali <samir.musali@logdna.com>
smusali
pushed a commit
to leeliu/charts
that referenced
this pull request
Feb 6, 2019
Signed-off-by: Chaoran Yu <yuchaoran2011@gmail.com> Signed-off-by: Samir Musali <samir.musali@logdna.com>
towolf
pushed a commit
to towolf/charts
that referenced
this pull request
Feb 7, 2019
Signed-off-by: Chaoran Yu <yuchaoran2011@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed kubeflow/spark-operator#390.