Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

feat(keycloak): add availability to expose extra port on sts #11162

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

jBouyoud
Copy link
Contributor

@jBouyoud jBouyoud commented Feb 5, 2019

What this PR does / why we need it:

In order to configure a port restriction on Keycloak admin console (https://github.com/keycloak/keycloak-documentation/blob/master/server_admin/topics/threat/admin.adoc#port-restriction) let the possibilty to the users to expose a custom port on the statefulset

Which issue this PR fixes

None

Special notes for your reviewer:

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

Signed-off-by: Julien Bouyoud <jbouyoud@leadformance.com>
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Feb 5, 2019
@thomasdarimont
Copy link
Collaborator

Hi @jBouyoud this looks interesting!

Out of curiosity, how do you configure Keycloak to expose the admin console on a different port?

@jBouyoud
Copy link
Contributor Author

jBouyoud commented Feb 6, 2019

Hi,

You can find the link to achieve this modification in the description of this PR (https://github.com/keycloak/keycloak-documentation/blob/master/server_admin/topics/threat/admin.adoc#port-restriction).
After that I declare a k8s service for http-admin and an ingress in my chart that depends on keycloak chart.

@jBouyoud
Copy link
Contributor Author

jBouyoud commented Feb 7, 2019

Hi @thomasdarimont ,

Does anything missing to be able to merge this PR ?

Copy link
Collaborator

@thomasdarimont thomasdarimont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jBouyoud, thomasdarimont

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Feb 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6e2dcd7 into helm:master Feb 7, 2019
@jBouyoud jBouyoud deleted the feat-keycloak-add-extra-port branch February 7, 2019 14:14
towolf pushed a commit to towolf/charts that referenced this pull request Feb 7, 2019
)

Signed-off-by: Julien Bouyoud <jbouyoud@leadformance.com>
VRanga000 pushed a commit to VRanga000/charts that referenced this pull request Feb 11, 2019
)

Signed-off-by: Julien Bouyoud <jbouyoud@leadformance.com>
Signed-off-by: Vikas Rangarajan <vikas_rangarajan@cable.comcast.com>
VRanga000 pushed a commit to VRanga000/charts that referenced this pull request Feb 11, 2019
)

Signed-off-by: Julien Bouyoud <jbouyoud@leadformance.com>
VRanga000 pushed a commit to VRanga000/charts that referenced this pull request Feb 11, 2019
)

Signed-off-by: Julien Bouyoud <jbouyoud@leadformance.com>
tbuchier pushed a commit to tbuchier/charts that referenced this pull request Feb 14, 2019
)

Signed-off-by: Julien Bouyoud <jbouyoud@leadformance.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants