[stable/redis-ha] Add Optional Prometheus Exporter Sidecar #11085
Conversation
Added support for an optional prometheus exporter sidecar container in each redis pod. Signed-off-by: Tim Mitrovich <tim@mitrovich.net>
helm-bot
added
size/M
|
/assign @ssalaues |
|
@tmitrovich: GitHub didn't allow me to assign the following users: ssalaues. Note that only helm members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* Added https://github.com/oliver006/redis_exporter to the sources list * Added ability to configure resource limits * Added ability to pull redis password from the existing redis secret so that we don't have plain text passwords in the config files * Added ability to configure port and metrics scraping path * Updated comments about the default install of redis-ha chart * Added livenessProbe to exporter container Signed-off-by: Tim Mitrovich <tim@mitrovich.net>
helm-bot
added
size/M
|
@ssalaues good suggestions. I implemented all of the suggestions. Have a look and let me know if there is anything else you think we should do. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ssalaues, tmitrovich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
* [stable/redis-ha] Add Optional Prometheus Exporter Sidecar Added support for an optional prometheus exporter sidecar container in each redis pod. Signed-off-by: Tim Mitrovich <tim@mitrovich.net> * [stable/redis-ha] Add Optional Prometheus Exporter Sidecar * Added https://github.com/oliver006/redis_exporter to the sources list * Added ability to configure resource limits * Added ability to pull redis password from the existing redis secret so that we don't have plain text passwords in the config files * Added ability to configure port and metrics scraping path * Updated comments about the default install of redis-ha chart * Added livenessProbe to exporter container Signed-off-by: Tim Mitrovich <tim@mitrovich.net>
Added support for an optional prometheus exporter sidecar container in each Redis pod.
Signed-off-by: Tim Mitrovich tim@mitrovich.net
What this PR does / why we need it:
This PR adds support for (optionally) injecting a prometheus Redis exporter container in each Redis pod as a sidecar. This addition makes it really easy to add metrics scraping to all Redis pods without having to install the exporters as separate pods. The exporter sidecar is disabled by default so until the sidecar is enabled, this chart will behave as it always have. That way existing users won't "accidentally" get the sidecar, but those that do want it can easily turn it on.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]