-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show links in table text #204
Conversation
@greyli I saw that table does not have tests yet for Bootstrap 5. Shall I make an issue for that? |
@greyli can you review and hopefully merge this PR please? Thanks. |
Thanks, I will review it this weekend. Please add docs for the newly added parameters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Could you add some unit tests and update the changelog?
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
=======================================
Coverage 97.01% 97.01%
=======================================
Files 1 1
Lines 134 134
Branches 23 23
=======================================
Hits 130 130
Misses 1 1
Partials 3 3 Continue to review full report at Codecov.
|
Merged, thanks! |
Please review, fixes most important part of #118 which can be closed IMHO.
fixes #118