Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Add e2e-tests for react-hotkeys dependency #2966

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adwait-godbole
Copy link
Contributor

Fixes #2380

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 1, 2025
@adwait-godbole
Copy link
Contributor Author

adwait-godbole commented Mar 1, 2025

I have noticed here that on the below page,

Screenshot from 2025-02-18 09-17-41

the cluster-chooser hotkey code over here:

https://github.com/headlamp-k8s/headlamp/blob/main/frontend/src/components/cluster/Chooser.tsx#L54-#L60

is not working when headlamp is deployed with all the additional plugins but clicking on the button manually is opening the popup.

(This is not the case when headlamp is deployed without any additional plugins. Without any additional plugins, the hotkey is working as expected and opening the cluster chooser popup without any manual intervention)

Signed-off-by: adwait-godbole <adwaitngodbole@gmail.com>
@adwait-godbole adwait-godbole force-pushed the feat/test-react-hotkeys branch from 21ae759 to 25ab237 Compare March 1, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test(s) for react-hotkeys dependency
1 participant