plugin/maps enable loops #2963
Open
plugin/maps enable loops #2963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
Signed-off-by: Fabian Schulz <fabian.schulz1@swisscom.com>
Signed-off-by: Fabian Schulz <fabian.schulz1@swisscom.com>
faebr
force-pushed
the
feature/map-enable-loops
branch
from
971e6ff to
5b9e46c
Compare
sniok
requested changes
Mar 3, 2025
There was a problem hiding this comment.
Tested a simple case like this a -> b -> c -> d -> back to a and it works great, thanks for the contribution!
while visually it might be a bit messy now I think we can improve it later based on some real cases
Could you update the commits to follow our guidelines?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't remove edges which form a loop in the map.