app: backend: Add flag for watching plugins changes #2939
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
skoeva
force-pushed
the
plugins-watch-option
branch
from
ebff55f to
1aee38b
Compare
|
Backend Code coverage changed from 65.0% to 65.2%. Change: .2% 😃. Coverage report |
|
Backend Code coverage changed from 65.0% to 65.1%. Change: .1% 😃. Coverage report |
joaquimrocha
requested changes
Feb 24, 2025
skoeva
changed the title
skoeva
force-pushed
the
plugins-watch-option
branch
from
1aee38b to
7b99366
Compare
|
Backend Code coverage changed from 65.1% to 65.0%. Change: -.1% 😞. Coverage report |
illume
force-pushed
the
plugins-watch-option
branch
2 times, most recently
from
91ffcee to
4441ebe
Compare
|
Backend Code coverage changed from 65.0% to 65.0%. Change: 0% 😃. Coverage report |
|
A few small changes...
|
illume
reviewed
Feb 26, 2025
Dockerfile
Outdated
| @@ -95,4 +95,4 @@ USER headlamp | |||
| EXPOSE 4466 | |||
|
|
|||
| ENV HEADLAMP_STATIC_PLUGINS_DIR=/headlamp/static-plugins | |||
| ENTRYPOINT ["/headlamp/headlamp-server", "-html-static-dir", "/headlamp/frontend", "-plugins-dir", "/headlamp/plugins"] | |||
| ENTRYPOINT ["/headlamp/headlamp-server", "-html-static-dir", "/headlamp/frontend", "-plugins-dir", "/headlamp/plugins", "-watch-plugins-changes", "false"] | |||
There was a problem hiding this comment.
Added this. @joaquimrocha please review?
There was a problem hiding this comment.
Hrmm… Adding this seems to stop the container tests from passing.
There was a problem hiding this comment.
Is there a good reason for keeping this here? If it's being problematic I suppose we could remove it
|
Backend Code coverage changed from 65.0% to 65.0%. Change: 0% 😃. Coverage report |
illume
requested changes
Feb 26, 2025
joaquimrocha
requested changes
Feb 26, 2025
There was a problem hiding this comment.
Found a possible issue, as commented in line.
Also would it make sense to have it as false by default? It would break the behavior we currently have (where it's on unless -in-cluster), but I feel like the use cases for having it on by default are less than otherwise. I am fine if we don't make it false by default on the grounds of keeping the behavior we had.
skoeva
force-pushed
the
plugins-watch-option
branch
from
4441ebe to
aac4f48
Compare
|
Backend Code coverage changed from 65.0% to 65.3%. Change: .3% 😃. Coverage report |
This change creates a CLI flag in the backend + desktop for watching changes to the plugins or their directory. Stops watching for plugin changes in the container image. Fixes: #2894 Signed-off-by: Evangelos Skopelitis <eskopelitis@microsoft.com> Signed-off-by: René Dudfield <renedudfield@microsoft.com>
skoeva
force-pushed
the
plugins-watch-option
branch
from
aac4f48 to
deb2603
Compare
|
Backend Code coverage changed from 64.9% to 65.1%. Change: .2% 😃. Coverage report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change creates a CLI flag in the backend + desktop for watching changes to the plugins or their directory.
Fixes: #2894
Testing
Backend
make backendcd backend && ./headlamp-server -watch-plugins-changes falseDesktop
cd app && npm run buildcd dist/linux-unpacked && ./headlamp -watch-plugins-changes falseand ensure that the flag is passed in