-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: PluginSettings: Refactor local storage and plugin data #2671
base: main
Are you sure you want to change the base?
Conversation
005cabd
to
d2f8668
Compare
Last push adds backwards comp so that all settings wont be set to off or on |
I have tried to keep the changes as small as possible to accomplish everything it needs to, I am not using the map object to save information anymore, although to hit these targets I still had to use most of what I had reworked previously for this PR the targets it needs to hit were:
The plugin data comes from the backend, reused the same method of reaching it from the previous rework
The data is now trimmed down to just being the name and isEnabled, it is now being used the same way as the original settings where this local saved item is how new app start ups save plugin settings
The local storage handling logic checks for the old format and changes it to the new format |
d2f8668
to
56e912f
Compare
56e912f
to
c150408
Compare
Some things to do to avoid duplicating of logic:
|
c150408
to
83f279e
Compare
83f279e
to
98c1b58
Compare
98c1b58
to
6cea967
Compare
b39d2a4
to
93ed4b0
Compare
93ed4b0
to
47dfb30
Compare
pushing rebase of current main |
note: that last disabled e2e needs to be redone in a later PR as it is out dated with the changes made to two different branches, this branch and the plugins name change branch, this is in my stack for playwright changes I will be working on later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plugins setting stopped working, check the pod-counter plugin settings
d4019b4
to
5d0b9e7
Compare
5d0b9e7
to
f5db3d3
Compare
121d6ea
to
f71de47
Compare
f7991dc
to
f7d5e24
Compare
@vyncent-t It seems there’s conflicts now. Can you please fix them? Also, can you please check if the PR description is up to date? I see a lot of changes since the last PR description edit, so I guess if needs updating. |
This PR reduces the size of plugin information saved in local storage, it also introduces the getPlugins hook for fetching plugin information. Signed-off-by: Vincent T <vtaylor@microsoft.com>
Signed-off-by: Vincent T <vtaylor@microsoft.com>
f7d5e24
to
77e1d63
Compare
Fixes Issue #2595
Description
name
andisEnabled
status in local storage. This ensures plugin settings persist when closing and reopening the app.usePlugins
hook intolib/k8s/api/v2
Changes
name
andisEnabled
) in local storage.How to Test
headlampPluginSettings
headlampPluginSettings
name
andisEnabled
) are fetched from the backend and displayed correctly in the UI.Notes