Allow custom certificates in oidc mode #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When headlamp is run with the insecure-ssl flag we want to allow users to use unverified certificates as well for the oidc. Thus this patch updates the oidc client if we are running in insecure-ssl mode to allow unverified certificates.
ashu8912
force-pushed
the
allow-self-signed-certs-insecure-mode
branch
from
c83b5be to
7dc5ea0
Compare
|
Thanks @iaguis for setting up the test cluster :D |
|
fixes #127 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow oidc flow with custom certificates when run in insecure mode
Testing done
Done!! tested with setting up oidc auth flow with dex followed by untrusted cert
fixes #127