Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added content descriptions to CountryCodeDialog buttons TalkBack accessibility #452

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

m-nogas
Copy link
Contributor

@m-nogas m-nogas commented Nov 20, 2020

Added content descriptions to CountryCodeDialog to make the dismiss and clear query buttons accessible through TalkBack.

Ontario, Canada has recently introduced legislation mandating that apps are accessible to users with disabilities which will come into force on January 1st, 2021. Unfortunately, parts of your components are not accessible through TalkBack (e.g. the clear query button will read "unlabeled button" rather than a description that helps a visually impaired user understand what the button does). In order to keep using your components and comply with the legislation we will need the content descriptions that I've added here. Please let me know if you'd like anymore info. Thank you!

Reference: https://www.aoda.ca

…nd clear query buttons accessible through TalkBack
Copy link
Owner

@hbb20 hbb20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution

@hbb20 hbb20 merged commit 252decf into hbb20:master Nov 25, 2020
@hbb20
Copy link
Owner

hbb20 commented Nov 26, 2020

v2.4.2 has been published with these changes.. Please look check and let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants