Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize all resources with imageoptim removing 64.8% in library size #397

Merged
merged 1 commit into from
May 23, 2020

Conversation

danielgomezrico
Copy link
Contributor

I applied multiple lose-less compressionz algorithms with imageoptim on each resource of the project, including each flag and got:

Saved 828 KB out of 1,4 MB. 64,8 % per file on average (up to 95,9 %)

So this will make no visual changes but will improve the library.

@hbb20 hbb20 merged commit d55449e into hbb20:master May 23, 2020
@IslamSalah
Copy link
Contributor

Saved 828 KB out of 1,4 MB.

Hi @danielgomezrico, curious how you calculated this "828 KB" ?
As comparing APK size before/after this PR, using the apk analyzer, the diff was 616 KB

compare apks

@IslamSalah
Copy link
Contributor

cc @hbb20

@danielgomezrico
Copy link
Contributor Author

@IslamSalah the tool imageoptim prints that at the end of the process

@IslamSalah
Copy link
Contributor

IslamSalah commented Feb 5, 2021

@danielgomezrico Thank you for the quick reply. Seems like it included improvement both in app & ccp modules. wdyt?
however library users will be only concerned only about the latter module

@danielgomezrico
Copy link
Contributor Author

@IslamSalah sorry, I dont get your question, can you please reword it?

@IslamSalah
Copy link
Contributor

Saved 828 KB out of 1,4 MB

616 KB removed fom ccp
212 KB removed from app
@danielgomezrico

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants