Improve french translation #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this PR. If you have some time can you also make sure all other translations of country name are good? |
|
Sure, good idea :) |
|
Hello :) Any update on a potential merge of this PR? |
|
Oh... If it's an urgent requirement, I can merge in and release a new
version tonight (MDT).
…On Tue, Sep 10, 2019 at 08:29 m3-ra ***@***.***> wrote:
Hello :) Any update on a potential merge of this PR?
Thanks a ton!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#334?email_source=notifications&email_token=ABFQ32E57RBAU3RZZGGR4J3QI6VN5A5CNFSM4IKHQASKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6LJLEQ#issuecomment-529962386>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABFQ32DMM6AOMGJ7IE5737DQI6VN5ANCNFSM4IKHQASA>
.
|
|
New version 2.3.2 should reflect these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for the awesome project, saved us a ton of work in our app! :)
I just made a small change to the french translation to be closer to what a native would say.