Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance hub driver #2994

Merged
merged 8 commits into from
Feb 21, 2025
Merged

Enhance hub driver #2994

merged 8 commits into from
Feb 21, 2025

Conversation

hathach
Copy link
Owner

@hathach hathach commented Feb 19, 2025

Describe the PR
Improve host stack compatibility with pio-usb which has often out-of-frame usb transaction error.

  • Enhance hub driver, handles most of case where transfer result is not success and requeue interrupt endpoint
  • usbh retry up to 3 time if control transferred failed
  • update bsp for rp2040, allow to added new board that is not part of sdk e.g FruitJam
  • added tuh_connected() API
  • Temporarily change pico-pio-usb to forked PR at retry transaction up to 3 times for usb host sekigon-gonnoc/Pico-PIO-USB#159 to retry at transaction level with pio-usb

@tannewt @ladyada

Copy link
Owner Author

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hub works much better now, we can merge this

@hathach hathach merged commit 1cfc88d into master Feb 21, 2025
180 checks passed
@hathach hathach deleted the enhance-hub branch February 21, 2025 03:36
@rppicomidi
Copy link
Contributor

rppicomidi commented Feb 26, 2025

@hathach If I pull master branch, it does not build. The file family.c fails on #include "board.h" board.h:no such file or directory. Commit 9d2fd6c still builds fine. Did some change not get pushed?

@hathach
Copy link
Owner Author

hathach commented Feb 26, 2025

@hathach If I pull master branch, it does not build. The file family.c fails on #include "board.h" board.h:no such file or directory. Commit 9d2fd6c still builds fine. Did some change not get pushed?

which BOARD you are building with, and your specific make/cmake commaand. I make some changes to the rp2040 bsp in the PR as well.

@rppicomidi
Copy link
Contributor

I am using the VS Code IDE. See issue #3004

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants