Deduplicate library directory arguments when testing libraries #4105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chpatrick, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dcoutts, @ezyang and @ttuegel to be potential reviewers. |
|
Thanks, LGTM! Let's wait for the build to green, then merge. |
|
Not to steal your thunder, but I want to rebase my PR :). |
nh2
added a commit
to nh2/cabal
that referenced
this pull request
Jun 1, 2018
… and `PD.extraLibDirs`. Should help with big invocations as found in NixOS/nixpkgs#41340.
5 tasks
nh2
added a commit
to nh2/cabal
that referenced
this pull request
Jun 1, 2018
… and `PD.extraLibDirs`. Should help with big invocations as found in NixOS/nixpkgs#41340.
colonelpanic8
pushed a commit
to colonelpanic8/cabal
that referenced
this pull request
Jun 4, 2018
… and `PD.extraLibDirs`. Should help with big invocations as found in NixOS/nixpkgs#41340.
nh2
added a commit
to nh2/cabal
that referenced
this pull request
Jun 10, 2018
… and `PD.extraLibDirs`. Should help with big invocations as found in NixOS/nixpkgs#41340.
nh2
added a commit
to nh2/cabal
that referenced
this pull request
Jun 14, 2018
… and `PD.extraLibDirs`. Should help with big invocations as found in NixOS/nixpkgs#41340.
23Skidoo
pushed a commit
to nh2/cabal
that referenced
this pull request
Jun 20, 2018
… and `PD.extraLibDirs`. Should help with big invocations as found in NixOS/nixpkgs#41340.
23Skidoo
pushed a commit
that referenced
this pull request
Jun 20, 2018
…LibDirs`. Should help with big invocations as found in NixOS/nixpkgs#41340.
nh2
added a commit
to nh2/cabal
that referenced
this pull request
Jul 17, 2018
… and `PD.extraLibDirs`. Should help with big invocations as found in NixOS/nixpkgs#41340.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3974. The same problem also affects the inherited library directories.