Add formatPath function #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergmark
reviewed
Sep 17, 2019
There was a problem hiding this comment.
Thank you @robbiemcmichael! Looks great, I added a comment inline.
Exposes functions for formatting a `JSONPath` as a `String` so that they can be used for more than formatting error messages.
robbiemcmichael
force-pushed
the
format-path
branch
from
9e9861f to
0ca4679
Compare
|
@bergmark I've made the changes. The build seems to be failing with some versions of GHC but I don't think it's related to my changes. |
bergmark
approved these changes
Sep 23, 2019
|
Thanks! I'll try to look into the build failures soon. |
|
🎉 |
gdevanla
added a commit
to gdevanla/aeson
that referenced
this pull request
Oct 17, 2019
gdevanla
added a commit
to gdevanla/aeson
that referenced
this pull request
Oct 24, 2019
|
@bergmark Any chance of a Hackage release in the near future? I was hoping to make use |
|
I'll do it right now, thanks for the reminder! |
|
That was quick! Thanks 😄 |
bergmark
added a commit
that referenced
this pull request
Feb 6, 2020
* Add section on Development Workflow * Referenced issue #773 to provide additional context, * Add section on Development Workflow Summarize notes discussed at #733 * clean up CONTRIBUTING.md * Update stack-nightly The update required to accommodate changes to version of Diff packages. * rollback changes to stack nightly * update stack-nightly.yaml. Required to be compatible with changes done on issue PR #729 * update CONTRIBUTING.md with accurate listing the yaml files, clarify instructions * add command line details in CONTRIBUTING.md * Add cabal-install instructions Co-authored-by: Adam Bergmark <adam@bergmark.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes a function to format a
JSONPathas aStringso that it can be used for more than formatting error messages.