Show permissions error on KV when you don't have access to create a s… #8170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecret (#8133) * add catch for fail on save. isError is not being set to true, so set it in the catch * add conditionally to only catch 403 permission errors. Otherwise it will catch and return an unhelpful error message for when you are trying to save a duplicate secret * add in code comment * remove catch and pass version 2 secret model to Error handler inside template * replace Error model with modelForData to catch errors on the correct model * add back in space * replace error model with modelForData
kalafut
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport for #8133, which fixes a bug where errors were not being caught because the wrong model was being passed into the KV secret engine's create and edit partials.