Create .bundle and set group when running container #7684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this is not set, `make website` fails due to permission errors in the docker container Fixes hashicorp#5589. Side note: it takes **a lot** to build and run the application. I believe several stuff could be improved here, starting with the fact that the `netlify` image is about 4gb which seems completely unnecessary.
|
|
|
@marcosnils Thanks! I'll let @tyrannosaurus-becks comment on the PR itself since I'm on Mac and don't get the error, but I did want to mention that we too are not content with the large image size and poor performance of this build. Improving the local docs development experience is definitely something we're investigating. |
There was a problem hiding this comment.
I can confirm this works for Linux on my Ubuntu-based machine. @kalafut can you confirm it still works on your Mac?
|
@tyrannosaurus-becks Yep, works fine! |
tyrannosaurus-becks
approved these changes
Oct 17, 2019
|
Anytime! Happy to make the 🌎 better one PR at the time 😃 |
catsby
added a commit
that referenced
this pull request
Oct 23, 2019
* master: (41 commits) changelog++ cli: fix json output for namespace list command (#7705) Update CHANGELOG.md Vault Agent Template (#7652) hostutil: disable host info collection on openbsd (#7699) Shamir seals now come in two varieties: legacy and new-style. (#7694) Update Title for AWS Marketplace (#7683) Bump go builder version Fix kv mod import and vendoring Fixing a typo with the sample payload (#7688) Update CHANGELOG.md Enable generated items for more auth methods (#7513) Update OIDC provider doc Update OIDC provider doc (#7693) Create .bundle and set group when running container (#7684) updates vendored api/client.go (#7692) Update circle config logical: remove unneeded error check in handleLogicalInternal (#7691) Update Go version Docs: add examples for when a seal rewrap is useful (#7689) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this is not set,
make websitefails due to permission errors in the docker containerFixes #5589.
Side note: it takes a lot to build and run the application. I believe several stuff could be improved here, starting with the fact that the
netlifyimage is about 4gb which seems completely unnecessary.