Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk/logical: handle empty token type string values as TokenTypeDefault #7273

Merged
merged 2 commits into from
Aug 14, 2019
Merged

sdk/logical: handle empty token type string values as TokenTypeDefault #7273

merged 2 commits into from
Aug 14, 2019

Conversation

calvn
Copy link
Contributor

@calvn calvn commented Aug 7, 2019

Fixes #7270

@calvn calvn added this to the 1.2.2 milestone Aug 7, 2019
@calvn calvn requested review from kalafut and briankassouf August 7, 2019 23:32
@kalafut
Copy link
Contributor

kalafut commented Aug 8, 2019

One test suggestion, otherwise LGTM.

@chrishoffman chrishoffman merged commit 5850e7b into master Aug 14, 2019
@chrishoffman chrishoffman deleted the handle-empty-tokentype branch August 14, 2019 13:45
chrishoffman pushed a commit that referenced this pull request Aug 14, 2019
@calvn @chrishoffman
sdk/logical: handle empty token type string values as TokenTypeDefault (
468f1b1 
#7273)

* sdk/logical: handle empty token type string values as TokenTypeDefault

* add test case for missing token_type value
@chrishoffman chrishoffman mentioned this pull request Aug 14, 2019
Merged
chrishoffman added a commit that referenced this pull request Aug 14, 2019
@chrishoffman
sdk/logical: handle empty token type string values as TokenTypeDefault (
2d69bce 
#7273) (#7312)

* sdk/logical: handle empty token type string values as TokenTypeDefault

* add test case for missing token_type value
@sivanag1974
Copy link

sivanag1974 commented Feb 24, 2020 •
edited
Loading

Even in vault 1.2.3, I am getting the error

./vault read -tls-skip-verify /auth/approle/role/abc_automation
Error reading auth/approle/role/adds_automation: Error making API request.

URL: GET https://<<>>/v1/auth/approle/role/abc_automation
Code: 500. Errors:

  • 1 error occurred:
    * unknown token type """"

[root@5a2ee033ssb8 tmp]# ./vault -v
Vault v1.2.3

@calvn
Copy link
Contributor Author

calvn commented Feb 26, 2020

@sivanag1974 Can you do a request against seal-status to check on the version of the server like so?

$ curl http://<your-vault-address>/v1/sys/seal-status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalafut kalafut kalafut left review comments

@briankassouf briankassouf briankassouf approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
1.2.2
Development

Successfully merging this pull request may close these issues.

Error 500: unknown token type "\"\"" when working with AppRole
5 participants
@calvn @kalafut @sivanag1974 @briankassouf @chrishoffman