Add Docs For Prometheus Metrics #6433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prometheus metrics were added as part of the Vault v1.1.0 release in PR #5308. But no documentation was created. This adds the configuration docs, but does not include the missing API docs. It also looks like the OpenAPI endpoint is missing the the details for /v1/sys/metrics?format=prometheus which is also not fixed with this change.
|
|
|
Closing for now, need to resubmit from personal fork due to CLA requirement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prometheus metrics were added as part
of the Vault v1.1.0 release in PR #5308.
But no documentation was created.
This adds the configuration docs, but
does not include the missing API docs. It
also looks like the OpenAPI endpoint is missing
the the details for /v1/sys/metrics?format=prometheus
which is also not fixed with this change.