Entity object in request object #4666
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishalnayak
force-pushed
the
request-entity
branch
from
cc01b70 to
8a1aa51
Compare
jefferai
reviewed
May 31, 2018
| @@ -128,9 +128,9 @@ type Request struct { | |||
| // token supplied | |||
| ClientTokenRemainingUses int `json:"client_token_remaining_uses" structs:"client_token_remaining_uses" mapstructure:"client_token_remaining_uses"` | |||
|
|
|||
| // EntityID is the identity of the caller extracted out of the token used | |||
| // to make this request | |||
| EntityID string `json:"entity_id" structs:"entity_id" mapstructure:"entity_id" sentinel:""` | |||
There was a problem hiding this comment.
I believe taking this out might cause an issue with control groups.
vishalnayak
force-pushed
the
request-entity
branch
from
8a1aa51 to
c1014a9
Compare
|
Superceded by #4681 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.